Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: F*: interfaces flag is a bit too expressive #397

Closed
W95Psp opened this issue Dec 20, 2023 · 1 comment · Fixed by #470
Closed

CLI: F*: interfaces flag is a bit too expressive #397

W95Psp opened this issue Dec 20, 2023 · 1 comment · Fixed by #470
Labels
cli Related to command line good first issue Good for newcomers

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Dec 20, 2023

hax into fstar --interfaces and hax into --include_namespaces accept the same kind of value (they share a same type and parser).

With the latter, the user can either:

  • exclude a namespace (prefix -);
  • include an item and all its local dependencies (prefix +);
  • include just an item without including its dependencies (prefix +!).

The former accepts the same grammar, but +! makes no sense: either we extract an interface for a module, or we don't, but there is no third option.

Here, either the Rust type InclusionClause should be made polymorphic to allow or not +!, or we should have a different type.

@W95Psp W95Psp added good first issue Good for newcomers cli Related to command line labels Dec 20, 2023
@W95Psp
Copy link
Collaborator Author

W95Psp commented Jan 29, 2024

This will be closed when #465 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant