Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hax): add extract-handshake to the driver #92

Merged
merged 1 commit into from
Mar 4, 2024
Merged

feat(hax): add extract-handshake to the driver #92

merged 1 commit into from
Mar 4, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Feb 6, 2024 •
edited
Loading

This PR adds a target to the driver to extract only handshake with dependencies extracted as interfaces.

This PR needs hax' cryspen/hax#498 PR.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Automation

Motivation and Context

Changes

Checklist

  • I have linked an issue to this PR
  • I have described the changes
  • I have read and understood the code of conduct, contribution guidelines, and contributor license agreement
  • I have added tests for all changes
  • I have tested that all tests pass locally and all checks pass
  • I have updated documentation if necessary

Fixes #

@W95Psp W95Psp requested a review from a team as a code owner February 6, 2024 14:51
@franziskuskiefer
Copy link
Member

@W95Psp what's the state of this?

@W95Psp
Copy link
Collaborator Author

W95Psp commented Feb 29, 2024

I thought this was merged already actually! I'm going to update the branch to see

karthikbhargavan
karthikbhargavan approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should merge this as soon as CI passes.

@W95Psp W95Psp enabled auto-merge March 4, 2024 11:48
@W95Psp W95Psp force-pushed the lucas/driver-extract-handshake branch from 9a68ee7 to 842e0dd Compare March 4, 2024 15:10
@W95Psp W95Psp merged commit 906df6b into main Mar 4, 2024
10 checks passed
@W95Psp W95Psp deleted the lucas/driver-extract-handshake branch March 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W95Psp @franziskuskiefer @karthikbhargavan