Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A number of small code quality improvements #83

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

jschneider-bensch
Copy link
Contributor

This PR adds more documentation to a bunch of smaller functions and renames some variables and functions to make naming more consistent and hopefully improve code legibility.

In addition it includes two changes that are meant to make the code more idiomatic:

  • Directly include the u8 encoding in the HandshakeType enum. Similar treatment could be applied to other u8-encoding enums in the future, e.g. AlertDescription.
  • Implement functions related to HandshakeData directly on the struct.

@jschneider-bensch jschneider-bensch requested a review from a team as a code owner December 21, 2023 16:24
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Making the code better one step at a time.
Only a few nits.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jschneider-bensch jschneider-bensch merged commit 45ac992 into main Jan 3, 2024
8 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/code-quality branch January 3, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants