bogo batch 1 #47
Merged
bogo batch 1 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable more tests - add run.sh script for running bogo tests - add server to bogo shim
There has been a cyclic dependency in the test that is resolved by moving the self-test to its own crate
- add better error codes - handle some more error cases
- send alerts - properly handle errors and print error messages
franziskuskiefer
force-pushed
the
franziskus/bogo-batch1
branch
from
df45c90 to
46920ff
Compare
duesee
suggested changes
Oct 4, 2022
duesee
reviewed
Oct 5, 2022
duesee
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organising bogo errors.
There's enough in here. @karthikbhargavan can you have a look so we can get a first batch and some of the necessary framework in?