Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround extraction issues #139

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Workaround extraction issues #139

merged 5 commits into from
Feb 12, 2025

Conversation

jschneider-bensch
Copy link
Contributor

This PR makes changes that are necessary for hax ProVerif extraction to work.

@jschneider-bensch jschneider-bensch requested a review from a team as a code owner February 11, 2025 16:12
@franziskuskiefer
Copy link
Member

Looks like this is still using an outdated action

franziskuskiefer
franziskuskiefer approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs cargo fmt before getting merged. Otherwise lgtm.

@jschneider-bensch
Copy link
Contributor Author

Thanks for updating the actions!

@franziskuskiefer
Copy link
Member

I thought we disabled the nix job?

@jschneider-bensch
Copy link
Contributor Author

Yeah, it's still in the base branch here. I've removed it and (unnecessarily, I guess) pulled in the flake.nix fix from #136

@jschneider-bensch jschneider-bensch merged commit 0caee30 into key-schedule-security Feb 12, 2025
2 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/proverif-key-schedule branch February 12, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@cmester0 cmester0 Awaiting requested review from cmester0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer