Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bertie Lax Typechecking #107

Merged
merged 18 commits into from
Apr 3, 2024
Merged

Bertie Lax Typechecking #107

merged 18 commits into from
Apr 3, 2024

Conversation

karthikbhargavan
Copy link
Collaborator

This PR addresses issue #86.

It requires some changes to the source code to generate better F* code.
In particular, we work around some issues around the use of question-marks until they are resolved in hax (see cryspen/hax#15)

It also requires some hand-edits to the generated F*, to add let rec for recursive functions, and to add a trait implementation for mutable Bytes

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Automation

Motivation and Context

This is part of the formal verification of Bertie.

Changes

Checklist

  • I have linked an issue to this PR
  • I have described the changes
  • I have read and understood the code of conduct, contribution guidelines, and contributor license agreement
  • I have added tests for all changes
  • I have tested that all tests pass locally and all checks pass
  • I have updated documentation if necessary

Fixes #

@karthikbhargavan karthikbhargavan marked this pull request as ready for review April 3, 2024 10:18
@karthikbhargavan karthikbhargavan requested a review from a team as a code owner April 3, 2024 10:18
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with the conflicts and comments addressed

@karthikbhargavan karthikbhargavan merged commit f612a59 into main Apr 3, 2024
10 checks passed
@karthikbhargavan karthikbhargavan deleted the lucas/fstar-wip branch April 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants