New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multisig.ride @ tokenized-staking #3

Open

deemru opened this issue Nov 21, 2022 · 0 comments

deemru commented Nov 21, 2022

LOW: this line reduces the usage of your multisig scheme to itself only:

invest-contracts/ride/multisig.ride

Line 45 in 5322159

StringEntry(KEY_MULTISIG, this.toString()),

HIGH: revokeConfirmation does not update the status based on quorum:

invest-contracts/ride/multisig.ride

Lines 180 to 182 in 5322159

    
           [ 
        
               StringEntry(confirmationsKey, makeString(confirmationsListUpdated, SEPARATOR)) 
        
           ], unit

as the opposite to confirmTransaction:

invest-contracts/ride/multisig.ride

Lines 145 to 148 in 5322159

    
           [ 
        
               StringEntry(confirmationsKey, confirmationsUpdated), 
        
               BooleanEntry(statusKey, confirmationsCount >= quorum) 
        
           ], unit

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment