New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brief audit of `executor.ride` #3

Open

1 of 2 tasks

deemru opened this issue Mar 13, 2023 · 0 comments

deemru commented Mar 13, 2023 •

edited

Loading

LOW: old key can be reused so past arguments can be reused in loop as no nonce

cip-waves-contracts/ride/executor.ride

Line 234 in 5c023c6

func updateSigner(newSignerPublicKey_: String, oldSignature_: String, newSignature_: String) = {

HIGH: uncertain serialization can lead to list argument manipulations (for example [ "", "0" ] and [ "0", "" ])

cip-waves-contracts/ride/executor.ride

Lines 205 to 208 in 5c023c6

    
           func foldFunc(acc: ByteVector, elem: String) = { 
        
               acc + elem.toBytes() 
        
           } 
        
           let argsBytes = FOLD<22>(functionArgs_, base58'', foldFunc)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment