chore: Renovate should run earthly commands for newer release branches #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Watts <[email protected]>
|
@phisco can you also take a look at this PR for crossplane-runtime that is similar in intent as crossplane/crossplane#6199? Thanks! 🙇♂️ |
phisco
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR updates the
matchBaseBranchesforpostUpgradeTasksthat renovate runs after updating dependencies. Earthly exists in every recent/supported branch except forrelease-1.16, so that is the only branch wheremakebased commands should still be running.These filters/comments were copied from core crossplane repo, i.e. crossplane/crossplane#6199.
Partially addresses crossplane/crossplane#6186, this does not address the fact that Renovate isn't allowed to run
makebased commands in renovate.yaml still - so Renovate PRs would still run into an issue forrelease-1.16.I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.