Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive NDArray in Jupyter notebook #1073

Closed
eismont21 opened this issue Aug 6, 2024 · 1 comment
Closed

False positive NDArray in Jupyter notebook #1073

eismont21 opened this issue Aug 6, 2024 · 1 comment

Comments

@eismont21
Copy link

eismont21 commented Aug 6, 2024

It was fixed for the .py files #565, but it is stilling failing in Jupyter notebooks.

@eismont21 eismont21 changed the title False positive for NDArray in Jupyter notebook False positive NDArray in Jupyter notebook Aug 6, 2024
@epage
Copy link
Collaborator

epage commented Aug 6, 2024

Currently, none of our language-specific terms recognize Jupyter, see https://github.com/crate-ci/typos/blob/master/crates/typos-cli/src/file_type_specifics.rs

iirc Jupyter allows multiple languages in a notebook, making them ore like Markdown, rather than having a way to tell by extension. Is that right?

What we'd need to address include

  • Should naively handle jupyter like we do for markdown (see also Ratatui #1055)?
  • If we handle it, should we assume its mostly Python people and just make it a synonym for Python?
  • If we want to handle these "cross-language" files, how far do we take that? For example, you could have comments in Python code referring to C code that you are using bindings for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants