Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected minimun-version field on latest v2 release #214

Closed
francesco-furlan opened this issue Mar 20, 2024 · 5 comments
Closed

unexpected minimun-version field on latest v2 release #214

francesco-furlan opened this issue Mar 20, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@francesco-furlan
Copy link

It seems #210 broke the action

Error: cpp-linter/cpp-linter-action/v2/action.yml (Line: 221, Col: 5): Unexpected value 'minimum-version'
Error: cpp-linter/cpp-linter-action/v2/action.yml (Line: 225, Col: 5): Unexpected value 'minimum-version'
Error: cpp-linter/cpp-linter-action/v2/action.yml (Line: 229, Col: 5): Unexpected value 'minimum-version'
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. cpp-linter/cpp-linter-action/v2/action.yml (Line: 221, Col: 5): Unexpected value 'minimum-version',cpp-linter/cpp-linter-action/v2/action.yml (Line: 225, Col: 5): Unexpected value 'minimum-version',cpp-linter/cpp-linter-action/v2/action.yml (Line: 229, Col: 5): Unexpected value 'minimum-version'
   at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load cpp-linter/cpp-linter-action/v2/action.yml
@ClemensLinnhoff
Copy link

I am having the same issue.

@shenxianpeng shenxianpeng added the bug Something isn't working label Mar 20, 2024
@shenxianpeng
Copy link
Collaborator

Sorry for the issue, please use cpp-linter/[email protected] instead of cpp-linter/cpp-linter-action@v2.

I found it was because our test action was not triggered recently and I also have the same issue as our users reported when I manually run it.

https://github.com/cpp-linter/test-cpp-linter-action/actions/runs/8356840074

ClemensLinnhoff added a commit to openMSL/sl-1-0-sensor-model-repository-template that referenced this issue Mar 20, 2024
ClemensLinnhoff added a commit to openMSL/sl-1-0-sensor-model-repository-template that referenced this issue Mar 20, 2024
* Update cache, checkout and upload-artifact from v3 to v4

Signed-off-by: ClemensLinnhoff <[email protected]>

* Use linter version v2.10.0 due to bug in current linter release: cpp-linter/cpp-linter-action#214

Signed-off-by: ClemensLinnhoff <[email protected]>

* Update file-existence-action

Signed-off-by: ClemensLinnhoff <[email protected]>

---------

Signed-off-by: ClemensLinnhoff <[email protected]>
@shenxianpeng
Copy link
Collaborator

shenxianpeng commented Mar 20, 2024

I revert the issue changes via #215 and published a new release v2.10.2

Right now the v2 version is back to work and you can use cpp-linter/cpp-linter-action@v2.

@2bndy5
Copy link
Collaborator

2bndy5 commented Mar 20, 2024

It's a shame. All I wanted to was generate a doc from the action.yml spec. This was so we could reduce the duplicated info... I'll find a different way to do that where the superfluous data (like minimum-version) is stored in a different file...

Sorry for the inconvenience. Big thanks to @shenxianpeng for prompt response and fix!

@ClemensLinnhoff
Copy link

Thanks for the quickfix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants