Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlinx Instant in Auditable #136

Open
yuanchen233 opened this issue Sep 12, 2024 · 0 comments
Open

Use Kotlinx Instant in Auditable #136

yuanchen233 opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@yuanchen233
Copy link
Collaborator

As mentioned in #314, we currently use Java Instant since Spring data JPA doesn't reconigze Kotlin Instant as a Basic Type for annotation @CreatedBy, this results all the Entity inherited this class using Java Instant, which is -- all database tables.

This brings confusion and unneeded conversion, as core and rest of webservice is using Kotlin Instant.

To cosider:

  • write a one-to-one mapper for Auditable class for Spring data JPA understand how to translate it.
  • override this annotation
  • stop using Spring data JPA, which might also make sense we don't need auto generated controllers for those data, and we are switching away from default CRUD methods..
@yuanchen233 yuanchen233 added the enhancement New feature or request label Sep 12, 2024
@pavliuc75 pavliuc75 self-assigned this Nov 22, 2024
@yuanchen233 yuanchen233 linked a pull request Dec 2, 2024 that will close this issue
@yuanchen233 yuanchen233 removed a link to a pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants