Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to help debugging/understanding the generated code (was: Annotations missing in devel) #5

Open
cpetig opened this issue May 30, 2020 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@cpetig
Copy link
Owner

cpetig commented May 30, 2020

in devel the comments are gone (which inputs and outputs are used for each invoke call), also it is no longer visible which operation is called (fix by defining and using an enum into g_registration)

@rafzi
Copy link
Collaborator

rafzi commented May 31, 2020

Wouldn't these changes conflict with the vision of having loops instead of linear code?

@cpetig
Copy link
Owner Author

cpetig commented May 31, 2020

Good point. I will probably need to put them into a different place (e.g. annotations on the arrays instead of on the code (which will probably be gone soon))

@cpetig
Copy link
Owner Author

cpetig commented May 31, 2020

Related to #13

@cpetig
Copy link
Owner Author

cpetig commented Jun 1, 2020

After implementing the reworked code I can only envision a comment with pseudo-code describing the network in human readable form:
E.g.
/* Inputs 10 (1,1)
0: 1 = QUANTIZE(10)
1: 4 = FULLY_CONNECTED(1,2,3)
2: 7 = FULLY_CONNECTED(4,5,6)
3: 0 = FULLY_CONNECTED(7,8,9)
4: 11 = DEQUANTIZE(0)
Outputs 11 (1.1) */
Do you think that this adds value to the generated file?

@rafzi
Copy link
Collaborator

rafzi commented Jun 2, 2020

Since the comment would be generated, I don't see any downside. It can only help with debugging!

@cpetig cpetig self-assigned this Jun 4, 2020
@cpetig cpetig added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 4, 2020
@cpetig cpetig changed the title Annotations missing in devel Add comments to help debugging/understanding the generated code (was: Annotations missing in devel) Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants