Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support json rpc provider #138

Closed
1 task
mfw78 opened this issue Jan 19, 2024 · 0 comments · Fixed by #150
Closed
1 task

chore: support json rpc provider #138

mfw78 opened this issue Jan 19, 2024 · 0 comments · Fixed by #150
Labels
bug Something isn't working

Comments

@mfw78
Copy link
Contributor

mfw78 commented Jan 19, 2024

Background

There may be times when a user wants to run the watch-tower without a websockets RPC provider.

Details

Depending upon the RPC URL passed, determine whether or not to use HTTP (JsonRpcProvider) or WS (WebSocketProvider).

Acceptance criteria

  • Support JsonRpcProvider and WebsocketProvider
@mfw78 mfw78 added the bug Something isn't working label Jan 19, 2024
@mfw78 mfw78 mentioned this issue Apr 2, 2024
Merged
1 task
@mfw78 mfw78 closed this as completed in #150 Apr 3, 2024
mfw78 added a commit that referenced this issue Apr 3, 2024
@mfw78
feat: jsonrpc and websockets (#150)
4f86cb4 
# Description
Adds support again for JSON-RPC now that infrastructure has been updated
and no longer has whacky state inconsistencies.

# Changes

- [x] Automatically determine whether to use `WebSockets` or
`JsonRpcProvider`

## How to test
1. Configure with JSON RPC provider, confirm starts.
2. Configure with websockets provider, confirm starts.

## Related Issues

Fixes #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: jsonrpc and websockets cowprotocol/watch-tower
1 participant
@mfw78