chore: update filter policy hourly #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging for hot fix |
anxolin
reviewed
Jan 11, 2024
| (context.chainId === SupportedChainId.GNOSIS_CHAIN ? 5 : 12); // 5 seconds for gnosis, 12 seconds for mainnet | ||
| if ( | ||
| filterPolicy && | ||
| block.number % (FILTER_FREQUENCY_SECS / blocksPerFilterFrequency) == 0 |
There was a problem hiding this comment.
looks too complicated...
why not just forget about the time frequency and define the block frequency
- 720 for gnosis
- 300 for other networks
also, better to use constant for these numbers (no magic numbers like 5 or 12)
same effect, but easier to read.
anxolin
reviewed
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the filter policy every hour
Changes