You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For this reason, I created this PR to make sure we stop watching the order #105
Proposal
The proposal is to make it more explicit in the doc that watch tower will stop indexing for any of the below errors except POLL_TRY_NEXT_BLOCK, POLL_TRY_AT_BLOCK or POLL_TRY_AT_EPOCH
Therefore, in particular ORDER_NOT_VALID should translate to a POLL_NEVER
🚨 Blocker: We can't make it coherent right now
Currently, there's an order for safe 0xAB8E66516e189ECf57415562183584659A814e4b which is meant to be checked in every block, but it raises the error ORDER_NOT_VALID instead of POLL_TRY_NEXT_BLOCK.
TO DO:
We could add an exception for this order, or ask nicely to the dev to use POLL_TRY_NEXT_BLOCK if that's the behaviour they seek
Document nicely so DEVs have the above mentioned behaviour clear
Problem
Currently, we re-try on every block for INVALID ORDERS, however this is incoherent with how we handle the error in the SDK
See here: https://github.com/cowprotocol/cow-sdk/blob/main/src/composable/ConditionalOrder.ts#L260
And the TEST: https://github.com/cowprotocol/cow-sdk/blob/main/src/composable/ConditionalOrder.spec.ts#L246
Here we have a bunch of validations we do for TWAPs, where
isValid
means, the order has some parameters that are wrong, so there's no point to poll in the future: https://github.com/cowprotocol/cow-sdk/blob/main/src/composable/orderTypes/Twap.spec.ts#L135For this reason, I created this PR to make sure we stop watching the order #105
Proposal
The proposal is to make it more explicit in the doc that watch tower will stop indexing for any of the below errors except
POLL_TRY_NEXT_BLOCK
,POLL_TRY_AT_BLOCK
orPOLL_TRY_AT_EPOCH
Therefore, in particular
ORDER_NOT_VALID
should translate to aPOLL_NEVER
🚨 Blocker: We can't make it coherent right now
Currently, there's an order for safe
0xAB8E66516e189ECf57415562183584659A814e4b
which is meant to be checked in every block, but it raises the errorORDER_NOT_VALID
instead ofPOLL_TRY_NEXT_BLOCK
.TO DO:
POLL_TRY_NEXT_BLOCK
if that's the behaviour they seekThe text was updated successfully, but these errors were encountered: