Hacky native price workaround #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
reviewed
Feb 12, 2025
squadgazzz
reviewed
Feb 12, 2025
squadgazzz
reviewed
Feb 12, 2025
squadgazzz
reviewed
Feb 12, 2025
squadgazzz
reviewed
Feb 12, 2025
squadgazzz
approved these changes
Feb 12, 2025
|
I guess we should prepare the infrastructure PR before merging this PR to main. |
New cli argument field is not mandatory, it can be not specified at all, so I think it is ok to merge it before infra PR ready. |
If that really works, then we are fine to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of an option to set alternative token price (approximated) for any other native token.
This feature is a workaround for obtaining native price for tokens which are not supported in our currently available sources, and it is safe to use such simple token substitution (like mapping csUSDL to DAI).
Changes
CachingNativePriceEstimator, usedDashMapfor optimal performance (this will be read only hash map)price_estimation::ArgumentsHow to test
Newly added tests.