Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executed_surplus_fee #3226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Jan 8, 2025

Description

Fixes #3180

Will be merged once frontend team confirms they applied a release where they stopped using executed_surplus_fee.

Frontend team confirmed 👍
Waiting for SAFE team to confirm.

Changes

  • Remove field that is no longer used.

How to test

Existing tests.

@sunce86 sunce86 self-assigned this Jan 8, 2025
@sunce86 sunce86 requested a review from a team as a code owner January 8, 2025 15:13
Copy link

github-actions bot commented Jan 8, 2025

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

  • You explicitly pointed out breaking changes.
  • You communicate the changes to affected teams.
  • You provide proper versioning and migration mechanisms.

Caused by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Remove executed_surplus_fee
5 participants