Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Native fee calculation #2706

Closed
sunce86 opened this issue May 8, 2024 · 2 comments
Closed

feat: Native fee calculation #2706

sunce86 opened this issue May 8, 2024 · 2 comments

Comments

@sunce86
Copy link
Contributor

sunce86 commented May 8, 2024

Problem

#2701 (comment)

Should we skip converting the total fee to sell token before converting it into native token?

This might introduce difference in the final result, since we use different external prices to convert into native token.

Solver team might also have some comments on this cc @harisang @fhenneke

@fhenneke
Copy link

fhenneke commented Jun 3, 2024

Are you referring to the fee solvers set to cover execution costs?
Then we would have to coordinate with solvers as they would have the change their algorithms.
In the (hopefully somewhat) near future we might change the accounting to never use the fee computed by the autopilot: protocol fees are not computed there anyways[0] and the network fee would just count towards slippage. Then it does not matter how it is computed. It would just be a way of communicating the directional price of orders to the driver.

[0]: It would be great if they were, though. E.g. as additional entry in the fee_policies table or a new table. Having code for protocol fees in the autopilot to check scores and populate protocol fees for consumption in our accounting would really help.

Copy link

github-actions bot commented Aug 3, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants