Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove workaround for zeroex orders signed for tx.origin == 0x0000 #2693

Closed
MartinquaXD opened this issue May 6, 2024 · 2 comments
Closed

chore: Remove workaround for zeroex orders signed for tx.origin == 0x0000 #2693

MartinquaXD opened this issue May 6, 2024 · 2 comments

Comments

@MartinquaXD
Copy link
Contributor

Background

Some solvers currently use these zeroex RFQ orders in their quotes which are actually invalid and lead to reverts in the zeroex contract when simulating them.
We already have a workaround specifically for this case but it should be removed as soon as solvers stop sending these invalid quotes.

Acceptance criteria

TODOs referencing this issue got removed.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jul 6, 2024
@mfw78 mfw78 removed the stale label Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinquaXD @mfw78