Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove exhaustive e2e tests for surplus fee #2468

Closed
fleupold opened this issue Mar 5, 2024 · 3 comments · Fixed by #2561
Closed

chore: Remove exhaustive e2e tests for surplus fee #2468

fleupold opened this issue Mar 5, 2024 · 3 comments · Fixed by #2561
Assignees
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@fleupold
Copy link
Contributor

fleupold commented Mar 5, 2024

Background

We spend about 20% of our time in the e2e tests for protocol fees. This is too long for a single fee policy. We do now have faster driver integration tests which should be used to test different behaviors. e2e should be reserved for the basic check that protocol fees work (but not all permutations of possible cases)

Image

Acceptance criteria

Have a single test case for protocol fees which combines different fee policies in their most commonly used path

@fleupold fleupold added E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details and removed E:3.1 Driver Colocation See https://github.com/cowprotocol/pm/issues/14 for details labels Mar 5, 2024
@squadgazzz squadgazzz self-assigned this Mar 19, 2024
@squadgazzz
Copy link
Contributor

squadgazzz commented Mar 19, 2024

Have a single test case for protocol fees which combines different fee policies in their most commonly used path

Is it really possible to create a single case for all the policies? For different policies, we have to start autopilot with different configurations. Not sure if restarting the autopilot for each policy kind within a single test case would be a reasonable approach.

@fleupold
Copy link
Contributor Author

I think we should have one test per fee policy (surplus, price improvement, volume) that tests a single instance, maybe the most interesting one. Testing the whole matrix (sell/buy, partial/non-partial, etc) can be left up to the driver tests.

@squadgazzz
Copy link
Contributor

squadgazzz commented Mar 21, 2024

A refactoring for simplification is also required: #2539 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants