You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We spend about 20% of our time in the e2e tests for protocol fees. This is too long for a single fee policy. We do now have faster driver integration tests which should be used to test different behaviors. e2e should be reserved for the basic check that protocol fees work (but not all permutations of possible cases)
Acceptance criteria
Have a single test case for protocol fees which combines different fee policies in their most commonly used path
The text was updated successfully, but these errors were encountered:
Have a single test case for protocol fees which combines different fee policies in their most commonly used path
Is it really possible to create a single case for all the policies? For different policies, we have to start autopilot with different configurations. Not sure if restarting the autopilot for each policy kind within a single test case would be a reasonable approach.
I think we should have one test per fee policy (surplus, price improvement, volume) that tests a single instance, maybe the most interesting one. Testing the whole matrix (sell/buy, partial/non-partial, etc) can be left up to the driver tests.
Background
We spend about 20% of our time in the e2e tests for protocol fees. This is too long for a single fee policy. We do now have faster driver integration tests which should be used to test different behaviors. e2e should be reserved for the basic check that protocol fees work (but not all permutations of possible cases)
Acceptance criteria
Have a single test case for protocol fees which combines different fee policies in their most commonly used path
The text was updated successfully, but these errors were encountered: