Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Filling in details of reusable approval warning does not work #77

Closed
MartinquaXD opened this issue Nov 29, 2023 · 0 comments · Fixed by #196
Closed

bug: Filling in details of reusable approval warning does not work #77

MartinquaXD opened this issue Nov 29, 2023 · 0 comments · Fixed by #196
Assignees
@mfw78
Labels
bug Something isn't working

Comments

@MartinquaXD
Copy link
Contributor

Problem

The approval warning is a reusable component that reads token and spender from its props. However when it gets rendered it doesn't actually fill in those values and instead literally displays {props.token} which is not desired.

Example on this page: https://github.com/cowprotocol/docs-v2/blob/main/docs/cow-protocol/tutorials/cow-swap/swap.mdx
@MartinquaXD MartinquaXD added the bug Something isn't working label Nov 29, 2023
@mfw78 mfw78 self-assigned this Nov 29, 2023
@mfw78 mfw78 mentioned this issue Dec 1, 2023
Merged
2 tasks
@mfw78 mfw78 closed this as completed in #196 Dec 1, 2023
mfw78 added a commit that referenced this issue Dec 1, 2023
@mfw78
feat: docusaurus 3 (#196)
9e0807c 
# Description

Docusaurus recently released `v3.0.0` (now `v3.0.1` with patch fixes).
The typedoc generator plugin was causing issues as `.md` is now
processed as `MDX`.

# Changes

- [x] Bump dependencies to docusaurus `v3.0.1`
- [x] Migrate all config files to typescript

## Related Issues

Fixes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfw78 mfw78

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: docusaurus 3 cowprotocol/docs
2 participants
@MartinquaXD @mfw78