Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Milkman repo links to actively maintained ones #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fedgiac
Copy link
Contributor

@fedgiac fedgiac commented Jan 6, 2025

Description

In the Milkman page, we're currently linking to the original repositories from the time of the grant.
Both repos are controlled by a third party and are not kept up-to-date with the latest changes to the Milkman contract. In particular:

  1. The bot/contracts aren't compatible with the bot we currently use in prod.
  2. The contracts contain a somewhat small security vulnerability and should not be used as a base for new contracts.

Changes

We update the links to point to the official version that we use in our infrastructure.

How to test

Try the new links, notice that they are managed by the DAO and have had recent changes from known contributors.

References

Internal discussion.

@fedgiac fedgiac requested a review from a team as a code owner January 6, 2025 09:39
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 6, 2025 9:40am

@fedgiac fedgiac enabled auto-merge (squash) January 6, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant