-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization #21
Comments
I would like to help with the localization. |
Hi, thanks for your offer 👍🏼 We will prepare the codebase while we transition to typescript (Issue #20). We will leave this open and inform you as soon as we did that. |
@Ein-Tim The localization branch is now ready for the German translation. |
Thanks for the update, I'll take a look at it later and will probably start with the translation tomorrow/on Sunday. If I need any advice or help, I can surely ping you here, right? |
Of course! |
Okay, so I took a look at the codebase, I assume I'll do the following: Do I have to translate any other files (which are providing the strings for the actual wallet card? |
That's right, you can also add "de" to the locales list in |
I now added the first translation to the files Not sure how to modify Should I provide a PR with my current changes or is there anything else left to do? |
Thanks for the contribution, you are right with the legal stuff, that would be odd. Feel free to open a PR. |
PR #26 is open for this. A little site note, the text is currently "Add your EU Digital Covid Vaccination Certificates to your favorite wallet app.", maybe we should remove "Vaccination" since this tool also supports recovered and tested certificates, or? |
It doesn't yet but we will remove that as soon as we support these certificates. |
I can translate in French if you want ;) |
@j3r3m067 That would be great! Would you also do the privacy policy and imprint? The latter is less important but would be nice for consistency. Otherwise just copy the english translation :) |
Dutch and Finnish translations are now finished. See #48. |
Hi, love the project |
@everdrone Great! Feel free to open a PR :) |
I can help with Bulgarian if needed. |
@vebaev The goal is to translate it for all EU countries, so I would appreciate it :) |
Hi guys, I'm ready for spanish translation. It is done. Sending PR now. |
Hi @marvinsxtr thanks for adding the colour palette to the main page, it's nicer and less complex for translating colours! Are you going to remove the translation keys for the colours then, or should we do this, in some next update? Many thanks! |
@mackonsti I was thinking about using them for alt texts so colorblind people can use the web app too but for that, we would have to translate the new colors too. Apart from that the extra translation keys do no harm i guess. |
have created a pull-request regarding norwegian translation |
PR sent for Swedish translation! :) |
Why didn't I get Contributor tag for this :/ |
Did I commit with wrong author config?
|
@unk1nd Your profile picture is now visible in the commit history for me so that seems to work. You may need to make another contribution though for GitHub to register you as a contributor. |
Hello everyone, Season Greetings! @marvinsxtr thanks again for your continuing updates! Please, can you kindly change/fix this word that Google Translate killed? 😅 It actually is not translated correctly, should be: Thank you for pushing this change the soonest. |
@mackonsti Fixed it with #144. |
I can offer to localise it to Romanian, how does this work? do I just open a pull request? where are the localised pages stored? |
@KoNickss Thank you for your offer. You can create a new folder with your translations in public/locales. There also need to be symlinks and some changes in a config file but I can do that part. Please open a pull request to the localization branch. |
Ok, I'll do so when I catch some time, thank you for the help and for this awesome project! |
@marvinsxtr almost done, do I put diacritics or not? Commonly they aren't used when typing in romanian for convenience (since you can tell most words out without them) but they are used in academic and/or professional backgrounds, so do I put them in or not? |
@KoNickss Just do what you find more suiting. |
@marvinsxtr I am so sorry for bothering you so much and I truly apologise, but I've encountered somewhat of a roadblock, in the privacy file I need to define "the", while in romanian "the" isn't a word, it's a suffix (ul/a) you add to words to make them articulate (Certificate = Certificat; The certificate = Certificatul), so how should I account for this? |
If 'the' is only applied to phrases like "covid certificate", "privacy policy" or "schema" these are already articulated, so I'll leave the 'the' empty, if any grammar problems arrise I'll sort them out but I doubt there will be any |
@KoNickss Sounds good. No worries. I don't think the index.yml on the localization branch already has the key share: in it, would be nice if you could add it with the translation as well. (See dev or main for reference) |
Localize the web app for all EU countries.
The text was updated successfully, but these errors were encountered: