Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): ibc-proto 0.44.0 and tendermint 0.36.0 #1206

Merged
merged 15 commits into from
Apr 30, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Apr 29, 2024

Closes: #1212

  • Update ibc-proto and tendermint.
  • Ignore dependabot alerts for ibc*, tendermint*, cosmwasm* and cw* crates.
  • Revert MSRV back to 1.71.1 as zeroize 1.8.0 is yanked.
  • Format .toml files using taplo.
  • Exclude ibc-client-tendermint-cw from publishing to crates-io.

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy changed the title chore(deps): ibc-proto 0.43.0 and tendermint 0.36.0. chore(deps): ibc-proto 0.43.0 and tendermint 0.36.0 Apr 29, 2024
@rnbguy rnbguy changed the title chore(deps): ibc-proto 0.43.0 and tendermint 0.36.0 chore(deps): ibc-proto 0.44.0 and tendermint 0.36.0 Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@ed4f8cd). Click here to learn what that means.
Report is 1 commits behind head on main.

❗ Current head 78924cd differs from pull request most recent head 64dcac0. Consider uploading reports for the commit 64dcac0 to get more accurate results

Files Patch % Lines
ibc-core/ics03-connection/types/src/events.rs 83.33% 1 Missing ⚠️
ibc-core/ics04-channel/types/src/events/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage        ?   64.44%           
=======================================
  Files           ?      229           
  Lines           ?    22051           
  Branches        ?        0           
=======================================
  Hits            ?    14210           
  Misses          ?     7841           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy marked this pull request as ready for review April 30, 2024 10:24
@rnbguy
Copy link
Member Author

rnbguy commented Apr 30, 2024

Once approved, I will add the taplo fmt commit.

@rnbguy rnbguy requested review from seanchen1991 and romac and removed request for romac April 30, 2024 13:06
@seanchen1991
Copy link
Contributor

Ignore dependabot alerts for ibc*, tendermint*, cosmwasm* and cw* crates.

Curious why we're opting to ignore these alerts.

@rnbguy
Copy link
Member Author

rnbguy commented Apr 30, 2024

Those particular packages are manually tracked.

  • tendermint and ibc-proto deps are inter-dependent.
  • cosmwasm deps are fixed to 1.5.x (maybe I can allow the patch updates).
  • cw-storage-plus and cosmwasm are inter-dependent.

@rnbguy rnbguy force-pushed the rano/update-ibc-proto-and-tendermint branch 2 times, most recently from 8dd2e01 to 603fcd9 Compare April 30, 2024 15:25
@rnbguy rnbguy added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 51453ab Apr 30, 2024
17 checks passed
@rnbguy rnbguy deleted the rano/update-ibc-proto-and-tendermint branch April 30, 2024 15:58
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* update ibc-proto and tendemrint

* compile tests

* update cargo lockfiles

* downgrade msrv to 1.71.1

zeroize 1.8 with MSRV 1.72 is yanked

* ignore patterns for depbot

* changelog entry

* ignore cw-storage-plus

* use consistent cargo-toml

* taplo for toml fmt

* nit

* Align cargo.toml entries

* put multiline description in separate section

* format toml

* exclude tendermint cw contract from publishing

---------

Signed-off-by: Rano | Ranadeep <[email protected]>
Co-authored-by: Sean Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update tendermint to 0.36.0 and ibc-proto to 0.44.0
2 participants