Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Senior officer vox start with their selected outerclothing #536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArtisticRoomba
Copy link
Contributor

About the PR

Voxes as a Senior Officer no longer start with a tank harness, and instead start with their selected outer clothing equipped.

Why / Balance

Fixes #498

I was bored

Technical details

Just comments out GroupTankHarness like I did for vox detectives on upstream. I can't do this fix on upstream and have you guys merge it as SeniorOfficer roles don't exist for upstream.

Media

Content Client_2nunO2Hu7g

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
I'm doing this in the style of an upstream CL

🆑

  • fix: Senior Officer Vox now start the shift with their selected outer clothing equipped. Previously it would be overridden by a tank harness and your clothing would start on the floor.

@@ -48,7 +48,7 @@
- type: roleLoadout
id: JobSeniorOfficer
groups:
- GroupTankHarness
# - GroupTankHarness # CD: fixes bug where vox detectives start with their outerclothing on the floor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inside of our namespace. Just remove the line. Additionally, does this break non-vox officers getting what they need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Senoir officer vox loadout broken
2 participants