Create vote for the time at CentCom #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We talked about this on discord. I don't remember exactly what the conclusion was but this should probably be changed & a way for admins to delay the round-end mid-CC would be ideal. |
yeah, I will dig out what we decided later |
|
closing this as it is not wanted. I will make a new PR (or re-open this) when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Create vote for the time at CentCom.
Closes #357
Why / Balance
Some rounds there needs to be more time at CC and it is often hard for admins
to gauge if this is wanted from the players. Additionally, CC can drag on for a
bit sometimes and this should hopefully solve this.
Technical details
Instead of checking for the CVar check for the value set in
RoundEndVoteSystem(formerlyShuttleVoteSystem). We then call a vote after the shuttle is launched.Breaking changes
Contains wizden changes.
ShuttleVoteSystem->RoundEndVoteSystemChangelog
A vote will be shown during the arrivals terminal to decide how long to spend at the CentCom station. The time will be the weighted average of the votes.