Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quterofi/manage_quickmarks to read/write directly from quterofi.toml instead of the standard quickmarks file #38

Closed
cortsf opened this issue Nov 4, 2024 · 0 comments · Fixed by #41

Comments

@cortsf
Copy link
Owner

cortsf commented Nov 4, 2024

By doing this quterofi/set_quickmarks could be deprecated and there would be no need to restart qb after updating quterofi's quickmarks in any way. Even manual updates (using a code editor) on quterofi.toml would need no action from inside qb for subsequent calls to quterofi userscripts to work as expected.

  • Consideri making this optional, by calling quterofi/manage_quickmarks with a --use-toml-file flag. So users could choose which variant to use.
  • Keep performance (for low end computers) in mind Moved to a new issue: Minimize number of quterofi.toml reads  #47
  • Provide scripts to convert from/to standard quickmarks files
@cortsf cortsf mentioned this issue Nov 12, 2024
@cortsf cortsf changed the title Consider making quterofi/manage_quickmarks to read/write directly from quterofi.toml instead of the standard quickmarks file Make quterofi/manage_quickmarks to read/write directly from quterofi.toml instead of the standard quickmarks file Dec 4, 2024
@cortsf cortsf closed this as completed in #41 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant