You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
where we can retain the same type signature where we use ExecutionType currently, but also allow downstream consumers to do stuff like getExecutionType('SELECT') === ExecutionType.LISTING as opposed to getExecutionType('SELECT') === 'LISTING' leading to better type safety.
As this is a BC breaking change, this will need to land in 3.0.
The text was updated successfully, but these errors were encountered:
Right now we export the
Dialect
andExecutionType
as string union types. While this works, it would be better to use string enums like:where we can retain the same type signature where we use
ExecutionType
currently, but also allow downstream consumers to do stuff likegetExecutionType('SELECT') === ExecutionType.LISTING
as opposed togetExecutionType('SELECT') === 'LISTING'
leading to better type safety.As this is a BC breaking change, this will need to land in 3.0.
The text was updated successfully, but these errors were encountered: