Container native chunk count is zero-indexed

[GuiltyDoggy]

Describe the bug

I am running a container-based image:
ostree-unverified-registry:quay.io/fedora-ostree-desktops/cosmic-atomic:41

When I run rpm-ostree upgrade, there is an output that states the number of chunks needed, followed by each chunk being downloaded. The number of chunks being downloaded begins with "0" and ends with N-1/N.

This isn't a huge issue, but it did make me think that my download had stalled at N-1 chunks when in reality it had completed and was processing the next step in the upgrade. I ended up issuing a rpm-ostree cancel command because of this confusion.

Reproduction steps

1. Rebase to a container-based image.
2. Run rpm-ostree upgrade
3. See that the steps for "Fetching ostree chunk" begins with "[0/N]" and ends with "[N-1/N]"

Expected behavior

"Fetching ostree chunk" messages should start with "[1/N]" and end with "[N/N]".

Actual behavior

"Fetching ostree chunk" begins with "[0/N]" and ends with "[N-1/N]"

System details

rpm-ostree --version
rpm-ostree:
Version: '2024.9'
Git: bd152998332c2b11af671447d3fd311319d5b3a8
Features:

• rust
• compose
• container
• fedora-integration

Additional information

Sample output:

$ rpm-ostree upgrade
Pulling manifest: ostree-unverified-registry:quay.io/fedora-ostree-desktops/cosmic-atomic:41
Importing: ostree-unverified-registry:quay.io/fedora-ostree-desktops/cosmic-atomic:41 (digest: sha256:349154882b830fe58759d339cb6a8dc2b31d91c91a85a49866140bab25c511b7)
ostree chunk layers already present: 54
ostree chunk layers needed: 11 (703.6 MB)
[0/11] Fetching ostree chunk 605bc62d49c4fa0da99 (28.4 MB)... done
[1/11] Fetching ostree chunk b75bb0e1f52f5ba0764 (17.0 MB)... done
[2/11] Fetching ostree chunk fcddaeca3bf0e7b1b67 (10.1 MB)... done
[3/11] Fetching ostree chunk bb0d411b7c088b0060b (207.4 MB)... done
[4/11] Fetching ostree chunk ae9b4cc0a25e84bd71e (9.5 MB)... done
[5/11] Fetching ostree chunk 07583cfde09ca59e8cb (112.7 MB)... done
[6/11] Fetching ostree chunk 49ef1e28f215d331cad (87.3 MB)... done
[7/11] Fetching ostree chunk 8be9d8275555ce42e64 (29.9 MB)... done
[8/11] Fetching ostree chunk 412a99c0b1844823aa5 (24.7 MB)... done
[9/11] Fetching ostree chunk 6565539b3e891a2f0ce (170.1 MB)... done
[10/11] Fetching ostree chunk 1bc0a803f3e48f5543e (6.5 MB)... done
Checking out tree 5e7625d... done
Enabled rpm-md repositories: fedora-cisco-openh264 updates fedora updates-archive
Updating metadata for 'updates'... done
Updating metadata for 'updates-archive'... done
Importing rpm-md... done
rpm-md repo 'fedora-cisco-openh264' (cached); generated: 2024-03-11T19:22:31Z solvables: 3
rpm-md repo 'updates'; generated: 2025-01-20T03:50:05Z solvables: 18060
rpm-md repo 'fedora' (cached); generated: 2024-10-24T13:55:59Z solvables: 76624
rpm-md repo 'updates-archive'; generated: 2025-01-20T04:11:58Z solvables: 24799
Resolving dependencies... done
Checking out packages... done
Running pre scripts... done
Running post scripts... done
Running posttrans scripts... done
Writing rpmdb... done
Writing OSTree commit... done
Staging deployment... done
Pruned images: 0 (layers: 33)
Freed: 792.5 MB (pkgcache branches: 3)
Upgraded:
  distribution-gpg-keys 1.106-1.fc41 -> 1.107-1.fc41
  qt6-qtbase 6.8.1-10.fc41 -> 6.8.1-11.fc41
  qt6-qtbase-common 6.8.1-10.fc41 -> 6.8.1-11.fc41
  qt6-qtbase-gui 6.8.1-10.fc41 -> 6.8.1-11.fc41
Run "systemctl reboot" to start a reboot