add aqua and remove a function: api change #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Actually I don't use it anymore dans |
|
@jbcaillau Please review and merge. |
jbcaillau
reviewed
Aug 13, 2024
There was a problem hiding this comment.
@ocots any (other) lesson from Aqua.jl test?
There was a problem hiding this comment.
We can merge later waiting for more changes.
jbcaillau
approved these changes
Aug 13, 2024
|
@jbcaillau We should make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the function
since it is a type piracy. It is replaced by
remove(x, y).Not very important but it changes the api and I use it in
OptimalControl. So I have modified the Project.toml to go the release0.13.