From d14033573249d9588b5b8bd17172bb6354a0db05 Mon Sep 17 00:00:00 2001
From: Alex Pop - Zengenti <a.pop@zengenti.com>
Date: Tue, 1 Oct 2024 09:52:09 +0100
Subject: [PATCH] feat: targeting .net 8 and upgraded all packages (#3)

* feat: targeting .net 8 and upgraded all packages
* chore removed orphan references
---
 Dockerfile.localdevelopment.unit.specs           |  4 ++--
 global.json                                      |  7 +++++++
 .../Application.csproj                           |  3 ++-
 .../Domain.csproj                                | 15 +++------------
 .../LocalDevelopment.csproj                      |  5 +++--
 .../UriTypeConverter.cs                          |  5 ++---
 .../LocalDevelopment.Unit.Specs.csproj           | 16 ++++++++--------
 7 files changed, 27 insertions(+), 28 deletions(-)
 create mode 100644 global.json

diff --git a/Dockerfile.localdevelopment.unit.specs b/Dockerfile.localdevelopment.unit.specs
index a94d162..e2e5d7f 100644
--- a/Dockerfile.localdevelopment.unit.specs
+++ b/Dockerfile.localdevelopment.unit.specs
@@ -1,9 +1,9 @@
-FROM mcr.microsoft.com/dotnet/sdk:6.0-bullseye-slim AS base
+FROM mcr.microsoft.com/dotnet/sdk:8.0-bookworm-slim AS base
 
 WORKDIR /app
 EXPOSE 5000
 
-FROM mcr.microsoft.com/dotnet/sdk:6.0-bullseye-slim AS build
+FROM mcr.microsoft.com/dotnet/sdk:8.0-bookworm-slim AS build
 WORKDIR /src
 
 COPY ["src/Zengenti.Contensis.RequestHandler.Domain/", "src/Zengenti.Contensis.RequestHandler.Domain/"]
diff --git a/global.json b/global.json
new file mode 100644
index 0000000..dad2db5
--- /dev/null
+++ b/global.json
@@ -0,0 +1,7 @@
+{
+  "sdk": {
+    "version": "8.0.0",
+    "rollForward": "latestMajor",
+    "allowPrerelease": true
+  }
+}
\ No newline at end of file
diff --git a/src/Zengenti.Contensis.RequestHandler.Application/Application.csproj b/src/Zengenti.Contensis.RequestHandler.Application/Application.csproj
index 82ca566..49723fa 100644
--- a/src/Zengenti.Contensis.RequestHandler.Application/Application.csproj
+++ b/src/Zengenti.Contensis.RequestHandler.Application/Application.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <RootNamespace>Zengenti.Contensis.RequestHandler.Application</RootNamespace>
@@ -10,6 +10,7 @@
         <PackageId>Zengenti.Contensis.RequestHandler.Application</PackageId>
         <Company>Zengenti Ltd</Company>
         <OutputType>Library</OutputType>        
+        <LangVersion>12</LangVersion>        
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/src/Zengenti.Contensis.RequestHandler.Domain/Domain.csproj b/src/Zengenti.Contensis.RequestHandler.Domain/Domain.csproj
index c83834d..1ffd3a1 100644
--- a/src/Zengenti.Contensis.RequestHandler.Domain/Domain.csproj
+++ b/src/Zengenti.Contensis.RequestHandler.Domain/Domain.csproj
@@ -1,26 +1,17 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <RootNamespace>Zengenti.Contensis.RequestHandler.Domain</RootNamespace>
         <AssemblyName>Zengenti.Contensis.RequestHandler.Domain</AssemblyName>
         <OutputType>Library</OutputType>
+        <LangVersion>12</LangVersion>
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="Zengenti.Core" Version="6.3.2" />
-    </ItemGroup>
-
-    <ItemGroup>
-      <Reference Include="Microsoft.AspNetCore.Http.Abstractions">
-        <HintPath>..\..\..\..\..\Program Files\dotnet\shared\Microsoft.AspNetCore.App\6.0.16\Microsoft.AspNetCore.Http.Abstractions.dll</HintPath>
-      </Reference>
-      <Reference Include="Microsoft.AspNetCore.Http.Features">
-        <HintPath>..\..\..\..\..\Program Files\dotnet\shared\Microsoft.AspNetCore.App\6.0.16\Microsoft.AspNetCore.Http.Features.dll</HintPath>
-      </Reference>
-      <Reference Include="Microsoft.Extensions.Primitives" />
+      <PackageReference Include="Zengenti.Core" Version="7.0.1" />
     </ItemGroup>
 
     <ItemGroup>
diff --git a/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/LocalDevelopment.csproj b/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/LocalDevelopment.csproj
index f7b2c52..7cc8290 100644
--- a/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/LocalDevelopment.csproj
+++ b/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/LocalDevelopment.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <RootNamespace>Zengenti.Contensis.RequestHandler.LocalDevelopment</RootNamespace>
@@ -9,6 +9,7 @@
         <OutputType>Exe</OutputType>
         <PackageId>Zengenti.Contensis.RequestHandler.LocalDevelopment</PackageId>
         <Authors>Zengenti</Authors>
+        <LangVersion>12</LangVersion>
     </PropertyGroup>
 
     <ItemGroup>
@@ -19,7 +20,7 @@
     <ItemGroup>
       <PackageReference Include="CommandLineParser" Version="2.9.1" />
       <PackageReference Include="LazyCache.AspNetCore" Version="2.4.0" />
-      <PackageReference Include="YamlDotNet" Version="13.1.1" />
+      <PackageReference Include="YamlDotNet" Version="16.1.2" />
       <PackageReference Include="Zengenti.Contensis.Delivery" Version="16.0.2" />
       <PackageReference Include="Zengenti.Contensis.Management" Version="16.0.3" />
     </ItemGroup>
diff --git a/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/UriTypeConverter.cs b/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/UriTypeConverter.cs
index 15dcdbc..1d28581 100644
--- a/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/UriTypeConverter.cs
+++ b/src/Zengenti.Contensis.RequestHandler.LocalDevelopment/UriTypeConverter.cs
@@ -13,14 +13,13 @@ public bool Accepts(Type type)
         return type == UriType;
     }
 
-    // ReSharper disable once ReturnTypeCanBeNotNullable
-    public object? ReadYaml(IParser parser, Type type)
+    public object? ReadYaml(IParser parser, Type type, ObjectDeserializer rootDeserializer)
     {
         var uri = parser.Consume<Scalar>();
         return new Uri(uri.Value);
     }
 
-    public void WriteYaml(IEmitter emitter, object? value, Type type)
+    public void WriteYaml(IEmitter emitter, object? value, Type type, ObjectSerializer serializer)
     {
         // NOTE: Not needed for us, but leaving this as an example
         //var uri = (Uri)value;
diff --git a/tests/Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/LocalDevelopment.Unit.Specs.csproj b/tests/Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/LocalDevelopment.Unit.Specs.csproj
index b883dcf..64a6391 100644
--- a/tests/Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/LocalDevelopment.Unit.Specs.csproj
+++ b/tests/Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs/LocalDevelopment.Unit.Specs.csproj
@@ -1,24 +1,24 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
-        <LangVersion>10</LangVersion>
+        <TargetFramework>net8.0</TargetFramework>
+        <LangVersion>12</LangVersion>
         <ImplicitUsings>true</ImplicitUsings>
         <RootNamespace>Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs</RootNamespace>
         <AssemblyName>Zengenti.Contensis.RequestHandler.LocalDevelopment.Unit.Specs</AssemblyName>
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="FluentAssertions" Version="6.11.0" />
-        <PackageReference Include="NSubstitute" Version="5.0.0" />
-        <PackageReference Include="nunit" Version="3.13.3" />
-        <PackageReference Include="NUnit3TestAdapter" Version="4.5.0">
+        <PackageReference Include="FluentAssertions" Version="6.12.1" />
+        <PackageReference Include="NSubstitute" Version="5.1.0" />
+        <PackageReference Include="nunit" Version="4.2.2" />
+        <PackageReference Include="NUnit3TestAdapter" Version="4.6.0">
           <PrivateAssets>all</PrivateAssets>
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
         <PackageReference Include="TestStack.BDDfy" Version="4.3.2" />
-        <PackageReference Include="Verify.NUnit" Version="22.1.1" />
+        <PackageReference Include="Verify.NUnit" Version="26.6.0" />
     </ItemGroup>
 
     <ItemGroup>