Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote object definition doesn't fully support the needs in HTML #10

Open
rdsaunders opened this issue Apr 13, 2023 · 0 comments
Open

Quote object definition doesn't fully support the needs in HTML #10

rdsaunders opened this issue Apr 13, 2023 · 0 comments

Comments

@rdsaunders
Copy link
Contributor

I'm concerned that the quote object definition doesn't fully support the needs in HTML.

Current

{
  "type": "_quote",
  "id": "gOZ4Mg", // Hashed GUID
  "value": "Stay hungry, stay foolish",
  "properties": {
      "source": "Steve Jobs",
      "citation": "https://www.apple.com/stevejobs/"
   }
}

The value is correct and would largely represent a <blockquote> in HTML.

The source property has previously been used to represent the person that made the quote; this would usually be placed in a figcaption element below the blockquote.

However, citations fall into two parts a cite attribute which applies to the Blockquote, e.g.<blockquote cite="https://youtu.be/UF8uR6Z6KLc">Stay hungry stay foolish</blockquote> and the <cite> element for referencing the creative work.

e.g.

<figure>
<blockquote cite="{{url: https://youtu.be/UF8uR6Z6KLc}}">{{value: Stay hungry, stay foolish}}</blockquote>
<figcaption>{{source: Steve Jobs}} <cite>{{citation: Steve Jobs' 2005 Stanford Commencement Address}}</cite></figcaption>
</figure>

For that, reason I think we need to update the quote definition:
Addition of a URL property.

{
  "type": "_quote",
  "id": "gOZ4Mg", // Hashed GUID
  "value": "Stay hungry, stay foolish",
  "properties": {
      "source": "Steve Jobs",  
      "url": "https://youtu.be/UF8uR6Z6KLc"
      "citation": "Steve Jobs' 2005 Stanford Commencement Address"
   }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant