Re-write argument parsing #35
Conversation
Adds `parse_args`, `check_required_args`, and `check_unknown_args`. Signed-off-by: Jake Correnti <[email protected]>
Updates the argument parsing for `virtio-blk` to use new helper functions. Makes the `format=` argument optional and provides the default value `raw`. Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-net argument parsing to use new helper functions. Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-serial argument parsing to use the new helper functions Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-vsock argument parsing to use the new helper functions Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-fs argument parsing to use the new helper functions Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-input to use the new helper functions Signed-off-by: Jake Correnti <[email protected]>
Updates virtio-gpu to use the new helper functions Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
Updates the argument parsing in src/cmdline.rs to no longer use `args_parse` or `val_parse`. Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
default-image-format
branch
from
3f06cb5 to
c774914
Compare
|
The args needed to be in order for the virtio-blk arguments. The first virtio-blk arg was the root disk ( |
Not all were required, I believe? |
Maybe my phrasing here is wrong, but I'm talking about the order of the arguments for |
The previous method for parsing the command-line arguments required the device arguments, for example, to be in a hard-coded order, and they were all considered required. Additionally, if a specific argument was missing, or there were extra arguments, the error messages could be somewhat vague.
These changes allow for more granular error message, optional arguments that have a default value, and for the user to put the arguments in any particular order.
Fixes: #30