Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to edition = "2021" #45

Closed
pczarn opened this issue Jul 7, 2024 · 8 comments
Closed

Migrate to edition = "2021" #45

pczarn opened this issue Jul 7, 2024 · 8 comments

Comments

@pczarn
Copy link
Contributor

pczarn commented Jul 7, 2024

No description provided.

@waywardmonkeys
Copy link
Contributor

I was going to do this but noticed that these crates advertise (but don't validate) that they support a very old MSRV.

What should the MSRV policy be fore this and bit-vec?

@pczarn
Copy link
Contributor Author

pczarn commented Jul 8, 2024 •
edited
Loading

Oh right!! as a compromise I would recommend migrating to 2018 and wait a couple years to bump further to 2021. Serde requires us (optionally) having 2018 anyway!

I remember some crate having a cool MSRV/SemVer policy, but forgot what it was...

By the way, validation of MSRV is implemented here and you may copy it: https://github.com/pczarn/gearley/blob/master/.github/workflows/ci.yml#L61-L75

@pczarn pczarn mentioned this issue Jul 8, 2024
Open
@pczarn
Copy link
Contributor Author

pczarn commented Jul 8, 2024

Well, the most important question is: how important is MSRV and how much care should I dedicate to making the policy careful?

@pczarn pczarn changed the title Migrate to edition = "2021" Migrate to edition = "2018" Jul 16, 2024
@pczarn pczarn changed the title Migrate to edition = "2018" Migrate to edition = "2021" Jul 20, 2024
@pczarn
Copy link
Contributor Author

pczarn commented Jul 21, 2024

@waywardmonkeys Would you still like to do this for set and vec? An expert said Min. Supported Rust Version does not matter that much, because tooling/rustup makes it very easy to update rustc and the entire toolchain.

@pczarn
Copy link
Contributor Author

pczarn commented Jul 21, 2024

We should support rustc 1.68.

@waywardmonkeys
Copy link
Contributor

I will do it.

@pczarn
Copy link
Contributor Author

pczarn commented Jul 21, 2024

Thanks.

@pczarn
Copy link
Contributor Author

pczarn commented Dec 1, 2024

Fixed in #53

@waywardmonkeys I did it

@pczarn pczarn closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waywardmonkeys @pczarn