Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #9

Open
RangerMauve opened this issue Aug 27, 2020 · 3 comments
Open

Support Windows #9

RangerMauve opened this issue Aug 27, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@RangerMauve
Copy link
Contributor

RangerMauve commented Aug 27, 2020

Some folks use Windows for development, we currently don't work on it at all since we assume POSIX file paths and use CLI utilities which might not exist in windows

  • Go through all the places where we use file paths, make sure to use path.join or path.resolve
  • Replace any platform specific CLI commands with JS code
  • Test on Windows VMs?

Alternatives:

  • Never support Windows? 😂
@dkastl
Copy link
Member

dkastl commented Aug 27, 2020

Issues like this often nobody wants to do, or just there is nobody using Windows to be able to test it.

I think it's a good idea to create issues to not forget about it, but sometimes it's fine to go ahead and keep the task for later.

@martinheidegger
Copy link
Member

If we start using #10 we can specify a test to run also on Windows which would make it easier to assure that tests run on all platforms. The only problem then would be to make sure that the right paths are used.

@martinheidegger
Copy link
Member

martinheidegger commented Aug 27, 2020

Another note: I think Windows is not relevant for the moment as rn-tape is mostly supposed to run on CI environments. If we want go get #11 working then this issue will become a lot more relevant.

@martinheidegger martinheidegger added the bug Something isn't working label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants