Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native dependencies #8

Open
RangerMauve opened this issue Aug 27, 2020 · 3 comments
Open

Support native dependencies #8

RangerMauve opened this issue Aug 27, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@RangerMauve
Copy link
Contributor

RangerMauve commented Aug 27, 2020

At the moment, native dependencies aren't going to get loaded into the RN app. This means that only pure JS projects will work.

I think it'd be good to have a CLI flag or something that specifies we need to run react-native link on the module in the rntape repo before running the build.

One problem we'll run into is that globally installed rn-tape will error out if you try to link to different modules. Maybe it shouldn't be allowed unless it's a devDependency?

Not sure how native deps could work outside of using rn link. 🤔 Would appreciate pointers though.

@RangerMauve RangerMauve added the enhancement New feature or request label Aug 27, 2020
@martinheidegger
Copy link
Member

One problem we'll run into is that globally installed rn-tape will error out if you try to link to different modules.

THis means it might be related to #4 ?

I wonder why it worked with get-random-values-polypony but it did use native code(?!) but other than that: I think its an important requirement to support native dependencies!

@RangerMauve
Copy link
Contributor Author

I don't think it's related to #4, but I'm gonna be addressing #4 tonight.

Not sure why it worked with polypony either. 🤔 Maybe I'm misunderstanding something? I'll add tests later (maybe tomorrow?). Agreed that it's important to support. I don't think it'd be supported on expo though. 😅

@martinheidegger
Copy link
Member

I don't think it'd be supported on expo though. 😅

Yes, expo support would defeat the purpose of expo 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants