Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to expo 39 #17

Open
martinheidegger opened this issue Nov 5, 2020 · 5 comments
Open

Update to expo 39 #17

martinheidegger opened this issue Nov 5, 2020 · 5 comments

Comments

@martinheidegger
Copy link
Member

The current version of expo is 39, would be good to have updated tests.

@RangerMauve
Copy link
Contributor

How do you feel about setting expo and RN as peer-dependencies or something? That way the library being tested can define them and rn-tape could be updated less frequently.

Should be a quick fix in the memetime.

@RangerMauve RangerMauve mentioned this issue Nov 9, 2020
10 tasks
@martinheidegger
Copy link
Member Author

expo requires an update process with newer versions. So the ./expotape folder would needs to be updated for each version expo upgrade that only works backwards to a certain version (so you would need to maybe have multiple upgrade processes in future). The "right" way probably is to setup the expo or rn project with the specific version "on-the-fly" using expo init or react-native init for each version with a short setup script.

joy: "meme-time" is that a special time known when only meme's can help with the predicaments of the current situation?

@RangerMauve
Copy link
Contributor

Looking at the docs, it doesn't look like we needed to do anything to upgrade expo other than update the version this time.

Could this be closed for now?

@martinheidegger
Copy link
Member Author

Closed in #19

@martinheidegger
Copy link
Member Author

I just noticed that the deep link still points to the 38 sdk?

"react-native": "https://github.com/expo/react-native/archive/sdk-38.0.1.tar.gz",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants