Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make axelar-token contract upgradable #993

Open
maciejwitowski opened this issue May 22, 2024 · 0 comments · May be fixed by #841
Open

Make axelar-token contract upgradable #993

maciejwitowski opened this issue May 22, 2024 · 0 comments · May be fixed by #841
Assignees
Labels

Comments

@maciejwitowski
Copy link
Contributor

From @raulk

Using OpenZeppelin's framework upgradable means:

  • move constructor to initialize
  • inherit from Initializable if it is the actual contract being deployed and inherit from onlyInitializing if it is a base class
  • all of the contracts that a contract inherits follows these rules
  • if user deployed have a deploy script and an upgrade script

Per https://docs.openzeppelin.com/upgrades-plugins/1.x/writing-upgradeable#initializing_the_implementation_contract
investigate if we need the constructor to have:

/// @custom:oz-upgrades-unsafe-allow constructor
constructor() {
    _disableInitializers();
}
  • make initialize onlyOwner (?)
  • update "initialize" method already in LinkedTokens to use new initialize method
  • ensure LinkedToken owner is properly set up
  • ensure deploy scripts make "msg.sender" the owner

Fixed by #841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants