Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[test-runner] Make transfer/app tests more modular and consistent #1078

Open
ArjunBhuptani opened this issue Apr 29, 2020 · 0 comments
Open
Labels
Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.

Comments

@ArjunBhuptani
Copy link
Member

App tests should probably be structured very similarly to our app validation libraries:

  • At the lowest level we should have some basic app tests that test things like senderDeposit <= freeBalance, which should be done for every app.
  • Then we should have a set of tests that is consistent across every transfer app that checks atomicity between hops, consistent params, etc. Should be done for every transfer.
  • Lastly we should have specialized tests for each app which check only app-specific failure cases.
@ArjunBhuptani ArjunBhuptani added p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. Chore Devops or refactoring task labels Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
None yet
Development

No branches or pull requests

1 participant