Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[node, types] Callback struct mistyped #1013

Open
LayneHaber opened this issue Apr 13, 2020 · 0 comments
Open

[node, types] Callback struct mistyped #1013

LayneHaber opened this issue Apr 13, 2020 · 0 comments
Labels
Chore Devops or refactoring task p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.

Comments

@LayneHaber
Copy link
Contributor

Describe the bug
Currently if you remove the DEPOSIT_* events from the node listener, the node fails to build. However, these events are only ever thrown by the client now, which means we may be abusing the event types in the node.
@LayneHaber LayneHaber added p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns. Needs Triage Needs to be looked at and prioritized. labels Apr 13, 2020
@ArjunBhuptani ArjunBhuptani added Chore Devops or refactoring task and removed Needs Triage Needs to be looked at and prioritized. labels Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Chore Devops or refactoring task p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LayneHaber @ArjunBhuptani