Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectError metadata missing when using connect-fastify + grpc transport #1406

Open
bobaaaaa opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1407
Open

ConnectError metadata missing when using connect-fastify + grpc transport #1406

bobaaaaa opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1407
Assignees
Labels
bug Something isn't working

Comments

@bobaaaaa
Copy link

bobaaaaa commented Jan 24, 2025

Describe the bug

When throwing a ConnectError with special metadata fields on the (connect-fastify) server, the metadata fields are not part of the headers anymore in the client with grpc transport.

I tried to fix the bug by myself but give up at the end. My last guess was, that the metadata fields are dropped/overridden or not correctly converted to the http header. The fastify plugin code did not receive the error http headers.

To Reproduce

I created a reproducible project: https://github.com/bobaaaaa/connect-fastify-bug

Environment:

- "fastify": "5.2.1",
- "@bufbuild/protobuf": "2.2.3",
- "@connectrpc/connect": "2.0.1",
- "@connectrpc/connect-fastify": "2.0.1"
- node 22

Additional context

@bobaaaaa bobaaaaa added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants