From 5b2273b6b8d8aab2536191505bc544f5661cfac1 Mon Sep 17 00:00:00 2001
From: Sri Krishna Paritala <skrishna@buf.build>
Date: Thu, 30 Nov 2023 23:43:01 +0530
Subject: [PATCH] Treat ResponseDefinition as optional

---
 .../connect-node-conformance/src/routes.ts    | 34 +++++--------------
 1 file changed, 9 insertions(+), 25 deletions(-)

diff --git a/packages/connect-node-conformance/src/routes.ts b/packages/connect-node-conformance/src/routes.ts
index 2e2e645e3..4418a6b1a 100644
--- a/packages/connect-node-conformance/src/routes.ts
+++ b/packages/connect-node-conformance/src/routes.ts
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { Code, ConnectError } from "@connectrpc/connect";
 import type { ConnectRouter, HandlerContext } from "@connectrpc/connect";
 import { ConformanceService } from "./gen/connectrpc/conformance/v1/service_connect.js";
 import { Any } from "@bufbuild/protobuf";
@@ -84,19 +83,13 @@ export default ({ service }: ConnectRouter) => {
     },
     async *serverStream(req, ctx) {
       const def = req.responseDefinition;
-      if (def === undefined) {
-        throw new ConnectError(
-          "missing response_definition",
-          Code.InvalidArgument,
-        );
-      }
-      appendProtoHeaders(ctx.responseHeader, def.responseHeaders);
-      appendProtoHeaders(ctx.responseTrailer, def.responseTrailers);
+      appendProtoHeaders(ctx.responseHeader, def?.responseHeaders ?? []);
+      appendProtoHeaders(ctx.responseTrailer, def?.responseTrailers ?? []);
       const anyReq = Any.pack(req);
       let reqInfo: ConformancePayload_RequestInfo | undefined =
         createRequestInfo(ctx, [anyReq]);
-      for (const res of def.responseData) {
-        await wait(def.responseDelayMs);
+      for (const res of def?.responseData ?? []) {
+        await wait(def!.responseDelayMs);
         yield {
           payload: new ConformancePayload({
             requestInfo: reqInfo,
@@ -106,7 +99,7 @@ export default ({ service }: ConnectRouter) => {
         // Only echo back the request info in the first response
         reqInfo = undefined;
       }
-      if (def.error !== undefined) {
+      if (def?.error !== undefined) {
         if (def.responseData.length === 0) {
           def.error.details.push(Any.pack(createRequestInfo(ctx, [anyReq])));
         }
@@ -121,14 +114,8 @@ export default ({ service }: ConnectRouter) => {
       for await (const req of reqIt) {
         if (def === undefined) {
           def = req.responseDefinition;
-          if (def === undefined) {
-            throw new ConnectError(
-              "missing response_definition",
-              Code.InvalidArgument,
-            );
-          }
-          appendProtoHeaders(ctx.responseHeader, def.responseHeaders);
-          appendProtoHeaders(ctx.responseTrailer, def.responseTrailers);
+          appendProtoHeaders(ctx.responseHeader, def?.responseHeaders ?? []);
+          appendProtoHeaders(ctx.responseTrailer, def?.responseTrailers ?? []);
           fullDuplex = req.fullDuplex;
         }
         reqs.push(Any.pack(req));
@@ -136,11 +123,8 @@ export default ({ service }: ConnectRouter) => {
           continue;
         }
         // fullDuplex, so send one of the desired responses each time we get a message on the stream
-        if (resNum >= def.responseData.length) {
-          throw new ConnectError(
-            "received more requests than desired responses on a full duplex stream",
-            Code.Aborted,
-          );
+        if (def === undefined || resNum >= def.responseData.length) {
+          break;
         }
         await wait(def.responseDelayMs);
         yield {