Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move native and JSON parsers to the same crate/module #562

Open
niklasdewally opened this issue Dec 30, 2024 · 1 comment
Open

Move native and JSON parsers to the same crate/module #562

niklasdewally opened this issue Dec 30, 2024 · 1 comment
Labels
area::parsing Related to essence / essence prime parsing kind::refactor Improvements to existing code (style, performance, clarity, ...)

Comments

@niklasdewally
Copy link
Collaborator

The native parser code is in the conjure_oxide crate, while the json parser is in conjure_core::parse. I think we should put these together, either in Conjure Oxide or in Conjure Core.
@niklasdewally niklasdewally added kind::refactor Improvements to existing code (style, performance, clarity, ...) area::parsing Related to essence / essence prime parsing labels Dec 30, 2024
@ozgurakgun
Copy link
Contributor

core including the parsing code is probably a good idea, is it not? makes sense for the two to be organised in a uniform way, yes. cc @leiamcalisteryoung for info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area::parsing Related to essence / essence prime parsing kind::refactor Improvements to existing code (style, performance, clarity, ...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ozgurakgun @niklasdewally