Top level constraint evaluation

[niklasdewally]

Now that constraints are a vector at the top level (#435), top level constraints are no longer being simplified as ands.

For example, savilerow/divide-mod-novar evaluates to:

true,
true,
true,
true,
true,
true,
true,
true,

We expect this to become

true

At the very least, we would want to do a total evaluation pass on this so that trivially true/false models can be identified.

In the future, we will be able to solve trivially true or false models without ever involving the solver.

[ozgurakgun]

In fact, and @YehorBoiar might hate me for this, but this is quite a good argument for saving a single Expr in the model...

Or maybe an Option<Expr> to make sure we aren't making up adhoc empty expressions.

[niklasdewally]

In fact, and @YehorBoiar might hate me for this, but this is quite a good argument for saving a single Expr in the model...

Or maybe an Option<Expr> to make sure we aren't making up adhoc empty expressions.

As a reminder, what motivated us to make it a vector in the first place?

[YehorBoiar]

@niklasdewally Issue #421 was the motivation behind it

@ozgurakgun I don't really mind. Felix did mention that it could be not a good idea, and I was ready to be having to rewrite that whole thing once again :)
However, I'm having a break from conjure-oxide untill the new year, so I wouldn't be able to contribute to that right now.

[niklasdewally]

Regardless of what happens to the top level expression itself, I am definitely in favour of keeping new_top as a vector and letting the rewriter turn that into an and (if necessary) for us.

…

On 10/12/2024 09:54, Yehor Boiar wrote: @niklasdewally <https://github.com/niklasdewally> Issue #421 <https:// github.com/conjure-cp/conjure-oxide/issues/421> was the motivation behind it @ozgurakgun <https://github.com/ozgurakgun> I don't really mind, Felix did mention that it could be not a good idea, and I was ready to be having to rewrite that whole thing to something else :) However, I'm having a break from conjure-oxide untill the new year, so I wouldn't be able to contribute to that right now. — Reply to this email directly, view it on GitHub <https://github.com/ conjure-cp/conjure-oxide#547#issuecomment-2531052693>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ AKQHNE47UCSFGMPDCNWURKL2E224BAVCNFSM6AAAAABTGFHQUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZRGA2TENRZGM>. You are receiving this because you were mentioned.Message ID: <conjure- ***@***.***>