Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Conjure and Minion solution checking using BTreeMap #532

Open
niklasdewally opened this issue Dec 2, 2024 · 0 comments
Open

Refactor Conjure and Minion solution checking using BTreeMap #532

niklasdewally opened this issue Dec 2, 2024 · 0 comments

Comments

@niklasdewally
Copy link
Collaborator

niklasdewally commented Dec 2, 2024

When checking solutions against the integration tester, I did a few hacky things with JSON string comparisons to get around the fact that HashMaps do not implement Eq, Hash, so cannot be compared, put in sets, etc.

Now we use BTreeMap instead, which does implement these, so some cleaning up is likely possible.

See also: #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant