Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the ServerBase API #198

Open
masomel opened this issue Dec 15, 2017 · 2 comments
Open

Refactor the ServerBase API #198

masomel opened this issue Dec 15, 2017 · 2 comments
Labels
application server

Comments

@masomel
Copy link
Member

masomel commented Dec 15, 2017 •
edited
Loading

ServerBase is a generic server API that can be used to implement any server-side functionality used in CONIKS components (e.g. key server, auditor service)

See https://github.com/coniks-sys/coniks-go/pull/195/files/c86968440e2d93561f539cfb617ab7692cde9465#diff-29ca0f53bd9a1d94bcc57fe038e0a55e
@vqhuy
Copy link
Member

vqhuy commented Dec 21, 2017

See the note: https://github.com/coniks-sys/coniks-go/blob/master/application/serverbase.go#L253

vqhuy added a commit that referenced this issue Dec 23, 2017
@vqhuy
First attemp to fix #198
761febf
vqhuy added a commit that referenced this issue Dec 23, 2017
@vqhuy
First attempt to fix #198
26a70c1
vqhuy added a commit that referenced this issue Jan 10, 2018
@vqhuy
First attempt to fix #198
536d5cb
@masomel
Copy link
Member Author

masomel commented Jan 30, 2018

From an internal discussion:

I moved EpochDeadline to ServerBaseConfig in #199, but it shouldn’t be here, since it’s server-specific value (in case of auditors with multiple servers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
application server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masomel @vqhuy