Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store calibration info in eeprom && make calibration accessible from UI #14

Open
6 of 8 tasks
rickyelopez opened this issue Sep 1, 2020 · 0 comments
Open
6 of 8 tasks

store calibration info in eeprom && make calibration accessible from UI #14

rickyelopez opened this issue Sep 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rickyelopez
Copy link
Member

rickyelopez commented Sep 1, 2020 •
edited
Loading

Right now all the touchscreen calibration constants are hard-coded and not changeable through software.

  • Store the constants associated with touchscreen calibration in EEPROM
    • can initialize these values with the ones that are currently hard-coded
    • can re-initialize (i.e. if eeprom is ever found to be empty) with the hard-coded values
  • Clean up the calibration routine (read: make the calibration routine actually make sense)
    • make this method callable through code
    • add button to diag page that launches calibration
    • make this method actually store the constants in eeprom
    • add a #define and associated method that clears the calibration constants from the eeprom (in case someone badly calibrates the screen and we need to reset it
@rickyelopez rickyelopez added the enhancement New feature or request label Sep 1, 2020
rickyelopez added a commit that referenced this issue Sep 6, 2020
@rickyelopez
touchscreen calibration now done with EEPROM!
cd2c285 
Automatically loads cal values from eeprom instead of using defaults
if the eeprom is empty or faulted, loads the defaults
this means that we can now add a button on the steering wheel somewhere
to recalibrate the touchscreen, and those values will actually be
stored!

Also made MasterConfig.h and started moving some #defines there. This
file will basically contain all the settings that you might want to
change

Added preprocessor-controlled debug blocks. If you want to debug, set
the appropriate values in MasterConfig.h and the debug code will be
compiled. If you don't want to debug, the code won't even be compiled!

addresses #14, next steps for this branch will be to do the same thing
for launch control values. UI functionality can probably be done in a
    future branch
rickyelopez added a commit that referenced this issue Oct 6, 2020
@rickyelopez
touchscreen calibration now done with EEPROM!
c78fbe1 
Automatically loads cal values from eeprom instead of using defaults
if the eeprom is empty or faulted, loads the defaults
this means that we can now add a button on the steering wheel somewhere
to recalibrate the touchscreen, and those values will actually be
stored!

Also made MasterConfig.h and started moving some #defines there. This
file will basically contain all the settings that you might want to
change

Added preprocessor-controlled debug blocks. If you want to debug, set
the appropriate values in MasterConfig.h and the debug code will be
compiled. If you don't want to debug, the code won't even be compiled!

addresses #14, started working on doing the same as above but for launch
profiles. Stopepd because Anastasia wanted to work on it.
@rickyelopez rickyelopez mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickyelopez