Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve duplicateNodes to only compile the generic tx address #70

Closed
JoshLafleur opened this issue Oct 2, 2024 · 0 comments · Fixed by #106
Closed

Improve duplicateNodes to only compile the generic tx address #70

JoshLafleur opened this issue Oct 2, 2024 · 0 comments · Fixed by #106
Labels
BMSW Tracker for all BMSW issues good first issue Good for newcomers help wanted Extra attention is needed improvement Improvement on an existing feature YAMCAN Tracker for all YAMCAN issues

Comments

@JoshLafleur
Copy link
Collaborator

Currently the BMSW generates the node address by specifying the node id. Remove this unnecessary specification
@JoshLafleur JoshLafleur added BMSW Tracker for all BMSW issues improvement Improvement on an existing feature YAMCAN Tracker for all YAMCAN issues good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2024
@JoshLafleur JoshLafleur linked a pull request Nov 24, 2024 that will close this issue
CANRX fixup #106
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BMSW Tracker for all BMSW issues good first issue Good for newcomers help wanted Extra attention is needed improvement Improvement on an existing feature YAMCAN Tracker for all YAMCAN issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CANRX fixup concordia-fsae/firmware
1 participant
@JoshLafleur