-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track spikes, bugfixes, test execution, and enable osx #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Jun 4, 2024
1. No need to wait on join() the monitoring thread, it is safely killed when duct process exits. 2. pass when ps fails (because inner process has finished) 3. Collect the first sample immediately rather than waiting for <sample-interval> Fixes con#36
Could be merged like this (it gets the job done) but test_execution probably should be refactored to be DRYer, ie use pytest parameters and a couple test utils. (Doing now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{output_prefix}usage.json
now includes "totals".{"183380": {"pcpu": 101.0, "pmem": 0.0, "rss": 11104, "vsz": 232924, "timestamp": "2024-06-04T10:26:59.614005-05:00"}, "totals": {"pmem": 0.0, "pcpu": 101.0}}
A run now looks like:
with memory peak usage and cpu peak usage added, and number of pids and pid info now left out of the final report
Fixes: #22
Fixes: #39
Fixes: #36
Fixes: #6
Fixes: #15